Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

桌面整理快捷键调整，以及 dock 插件图标出走问题修复 #2091

Merged
merged 3 commits into from
Jul 5, 2024
Merged

桌面整理快捷键调整，以及 dock 插件图标出走问题修复 #2091

merged 3 commits into from
Jul 5, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Jul 5, 2024

  • feat: [desktop] do not refresh whole desktop
  • fix: [262559/desktop] change default shortcut sequence
  • fix: [262623/dock] mount plugin showed in screen

max-lvs
max-lvs previously approved these changes Jul 5, 2024
View reviewed changes
@itsXuSt
feat: [desktop] do not refresh whole desktop
a2df949 
when some categories are not organized anymore.

Log: as title.
Johnson-zs
Johnson-zs previously approved these changes Jul 5, 2024
View reviewed changes
@itsXuSt
fix: [262559/desktop] change default shortcut sequence
a88dea8 
since key_win press event might be captured by the input-method, and
cause the `hide-by-one-click` didn't work, change the default modifier
key from key_win to key_alt.

Log: as title.

Bug: https://pms.uniontech.com/bug-view-262559.html
@itsXuSt
fix: [262623/dock] mount plugin showed in screen
80c46c3 
caused by linuxdeepin#2053
files

Log: fix issue about mount plugin

Bug: https://pms.uniontech.com/bug-view-262623.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在TypeClassifier::updateClassifier()方法中添加了一个空实现，这可能是一个遗漏，应该确认是否需要实现任何内容。
  • NormalizedMode::releaseCollection方法中的if (!d->classifier)检查可能是多余的，因为d->classifier在构造函数中被初始化为nullptr。
  • NormalizedMode::releaseCollection方法中的QString key = kCategory2Key.value(ItemCategory(category), "");可能会导致未定义行为，如果kCategory2Key中不存在category对应的键值。
  • NormalizedMode::moveFilesToCanvas方法的参数urls应该是一个const QList<QUrl>&类型，而不是const QMimeData*。
  • NormalizedMode::moveFilesToCanvas方法中的d->classifier->classify(url)调用可能不会按预期工作，因为classify方法可能不会返回url对应的分类。
  • NormalizedMode::onCollectionEditStatusChanged方法中的this->editing变量被声明但未在方法中使用，这可能是一个遗漏。
  • NormalizedMode::filterDropData方法中的mimeData->urls()调用可能不会按预期工作，因为mimeData可能不是一个有效的QMimeData对象，或者其urls()方法未正确实现。
  • NormalizedMode::onReorganizeDesktop方法中的d->classifier->updateClassifier()调用可能不会按预期工作，因为updateClassifier方法可能未正确实现。

是否建议立即修改:
是

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itsXuSt
Copy link
Contributor Author

itsXuSt commented Jul 5, 2024

/merge

@deepin-bot deepin-bot bot merged commit a08cfa0 into linuxdeepin:master Jul 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lvs max-lvs max-lvs approved these changes

@Johnson-zs Johnson-zs Johnson-zs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsXuSt @deepin-ci-robot @Johnson-zs @max-lvs