Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The top bar of the trash has become a separate window #2092

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

liyigang1
Copy link
Contributor

Trash is not an empty event sent in a child thread, causing show to execute in the child thread

Log: The top bar of the trash has become a separate window
Bug: https://pms.uniontech.com/bug-view-263093.html

Trash is not an empty event sent in a child thread, causing show to execute in the child thread

Log: The top bar of the trash has become a separate window
Bug: https://pms.uniontech.com/bug-view-263093.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • TrashDirIterator::hasNext()函数中,调用TrashHelper::instance()->trashNotEmpty()可能不会按预期工作,因为该函数是TrashHelper的私有成员函数。
  • TrashHelper::trashNotEmpty()函数被添加,但未在类定义中声明为公共或保护成员函数,可能导致访问错误。
  • TrashHelper::onTrashNotEmptyState()函数被重命名为trashNotEmpty(),但信号trashNotEmptyState()未在类定义中声明为公共成员函数,可能导致连接错误。
  • connect函数在TrashHelper::initEvent中被使用,但没有提供连接的目标对象,这可能导致未定义行为。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit f6ed908 into linuxdeepin:master Jul 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants