Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Setting "Open folder window in separate process" to check/uncheck is opposite to the actual situation #2100

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

liyigang1
Copy link
Contributor

Requirement modification

Log: Setting "Open folder window in separate process" to check/uncheck is opposite to the actual situation
Bug: https://pms.uniontech.com/bug-view-263787.html

…k is opposite to the actual situation

Requirement modification

Log: Setting "Open folder window in separate process" to check/uncheck is opposite to the actual situation
Bug: https://pms.uniontech.com/bug-view-263787.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • openInHomeDirectory函数中,配置文件的读取方式被修改为始终打开新窗口,这可能不符合预期行为。
  • openInUrls函数中,配置文件的读取方式被修改为始终打开新窗口,这可能不符合预期行为。
  • openWindowWithUrl函数中,配置文件的读取方式被修改为始终打开新窗口,这可能不符合预期行为。
  • FileOperatorMenuScene::triggered函数中,配置文件的读取方式被修改为始终打开新窗口,这可能不符合预期行为。
  • SideBarWidget::onItemActived函数中,配置文件的读取方式被修改为始终打开新窗口,这可能不符合预期行为。
  • FileOperatorHelper::openFilesByMode函数中,配置文件的读取方式被修改为始终打开新窗口,这可能不符合预期行为。
  • BaseItemDelegate::commitDataAndCloseActiveEditor函数中,对d->commitDataMutex的访问进行了优化,避免了不必要的锁操作。

是否建议立即修改:

这些修改可能会影响用户的行为和配置文件的使用方式。需要确认这些更改是否符合预期的功能,并确保它们不会引入新的问题。如果这些更改是故意的,应该在文档中更新相应的部分,以便用户了解这些变化。如果这些更改是无意的,应该立即恢复到原来的配置文件读取方式。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 4d78e41 into linuxdeepin:master Jul 11, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants