Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [vault] There is a vertical line on the widget. #2102

Merged

Conversation

GongHeng2017
Copy link
Contributor

The line is delate later, so add the QTimer::singleShot to wait is delate.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-249139.html

The line is delate later, so add the QTimer::singleShot to wait is delate.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-249139.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • VaultRemoveByNoneWidgetVaultRemoveByPasswordView中,使用QTimer::singleShot来延迟发射信号可能不是最佳选择,因为emit操作是线程安全的。
  • VaultRemovePages中的clearContents(true)调用可能会导致界面闪烁,因为它是异步操作。
  • getButtons().size() > 1检查在showRemoveProgressWidget方法中可能不是必要的,因为VaultRemovePages的布局应该已经确保了按钮的可见性。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 16d607a into linuxdeepin:master Jul 11, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants