Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When renaming a file in the icon view, if there are no other files below the file, the input displayed during file renaming is incomplete #2103

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

liyigang1
Copy link
Contributor

Calculate the height issue of editing

Log: When renaming a file in the icon view, if there are no other files below the file, the input displayed during file renaming is incomplete
Bug: https://pms.uniontech.com/bug-view-259517.html

…es below the file, the input displayed during file renaming is incomplete

Calculate the height issue of editing

Log: When renaming a file in the icon view, if there are no other files below the file, the input displayed during file renaming is incomplete
Bug: https://pms.uniontech.com/bug-view-259517.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • updateEditorGeometry函数中,使用auto关键字可能会导致代码可读性降低,建议使用明确的类型名。
  • fileview变量在声明后没有立即使用,可能是无用的代码,应该移除。
  • if条件判断中,fileview->size().height() > viewHelper->viewContentSize().height()这个条件可能会导致逻辑错误,因为viewContentSize可能不是fileview的全局尺寸,而size方法返回的是窗口大小。
  • setMaxHeight函数的参数使用了qMax函数,但没有检查maxHeight是否为负数,可能会导致setMaxHeight函数抛出异常。
  • sizeHint函数的使用可能会导致性能问题,因为它需要计算一次布局。如果这个函数调用不是很频繁,可以考虑使用minimumSize代替。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 24e95c4 into linuxdeepin:master Jul 11, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants