Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [vault] change ui size #2105

Merged

Conversation

GongHeng2017
Copy link
Contributor

change ui size

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-249143.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • VaultActiveFinishedViewinitUi函数中,waterProgress的固定大小被设置为90x90,但之前是100x100。如果这是有意为之,应该确认是否与设计规范一致。
  • VaultRemoveProgressViewVaultRemoveProgressView构造函数中,vaultRmProgressBar的固定大小从80x80增加到90x90。同样需要确认是否与设计规范一致。
  • VaultActiveFinishedViewinitUi函数中,play3布局的上下内边距从15和0增加到了22和0。这可能会影响布局的视觉效果,需要确认这是否是预期的更改。
  • VaultRemoveProgressViewVaultRemoveProgressView构造函数中,deletingLay布局的上下内边距被设置为0和22。这可能会影响布局的视觉效果,需要确认这是否是预期的更改。

是否建议立即修改:

  • 是,需要确认上述更改是否符合设计规范,并确保它们不会对用户界面产生负面影响。如果这些更改是必要的,应该在代码中添加相应的注释说明原因。如果这些更改是无意的,应该撤销它们以保持界面的一致性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit 11df9be into linuxdeepin:master Jul 11, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants