Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [emblem] performance optimization #2196

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Lighto-Ku
Copy link
Contributor

replace QIcon::paint func with QPainter::drawPixmap.

Log: performance optimization

replace QIcon::paint func with QPainter::drawPixmap.

Log: performance optimization
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在代码更改中,使用了drawPixmap方法替代paint方法来绘制图标,这可能是为了优化性能。但是,这种更改是否适用于所有类型的图标,需要进行充分的测试。
  • 注释中提到的“某些特殊情况下的图标”,可能需要更详细的分析或重构,以确保这种方法不会对其他图标类型造成负面影响。

是否建议立即修改:

  • 是,需要确保更改后的代码不会引入新的错误或性能问题,并且与项目的其他部分兼容。同时,应该提供更多的上下文信息,以便其他开发者理解这一更改的背景和影响。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, Lighto-Ku

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs Johnson-zs merged commit 5eb3c8c into linuxdeepin:develop/snipe-tmp Aug 12, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants