Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [workspace] animation issues #2203

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

Lighto-Ku
Copy link
Contributor

1.fix enter dir animation paint blurred pixmap.
2.fix paint blurred item when change view size.
3.fix view content disappeared in list mode when show detailview.

Log: fix animation issues
Task: https://pms.uniontech.com/story-view-36389.html

1.fix enter dir animation paint blurred pixmap.
2.fix paint blurred item when change view size.
3.fix view content disappeared in list mode when show detailview.

Log: fix animation issues
Task: https://pms.uniontech.com/story-view-36389.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ViewAnimationHelper::paintItems函数中,移除了对QPainter::SmoothPixmapTransform的设置,可能会影响图像的平滑度。确认这一改动是否符合设计要求。
  • EnterDirAnimationWidget::paintPix函数中,使用QPainter::saveQPainter::restore来保存和恢复状态,这可能会导致性能问题,特别是当绘制操作频繁时。建议使用更高效的绘制方法。
  • FileView::aboutToChangeWidth函数中,增加了对isIconViewMode()的检查,这是一个好的做法,以确保在特定的视图模式下执行操作。但是,如果这个函数在其他地方也被调用,那么这个检查可能不是必要的。

是否建议立即修改:

  • 是,需要确认移除QPainter::SmoothPixmapTransform是否符合设计要求,并评估对图像质量的影响。
  • 是,应该寻找更高效的绘制方法来替代QPainter::saveQPainter::restore,以避免不必要的性能开销。
  • 是,应该检查FileView::aboutToChangeWidth在其他地方是否也有类似的isIconViewMode()检查,以避免重复代码。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, Lighto-Ku

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs Johnson-zs merged commit 46dd8f3 into linuxdeepin:develop/snipe-tmp Aug 15, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants