Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: animation issue #2205

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

Lighto-Ku
Copy link
Contributor

enter dir issue of 3-party plugin.

Log: fix animation issue

enter dir issue of 3-party plugin.

Log: fix animation issue
add dci files license

Log: add dci license
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • WorkspaceWidget::setCurrentUrl函数中,对contentWidget的访问应该在curView不为空的前提下进行,以避免潜在的空指针异常。
  • WorkspaceWidget::handleViewStateChanged函数中,对contentWidget的访问同样应该在view不为空的前提下进行。
  • WorkspaceWidget::onAnimDelayTimeout函数中,对contentWidget的访问应该在view不为空的前提下进行。
  • 新增的文件后缀.dci应该有相应的文件处理逻辑或者文档说明其用途。
  • 检查EnterDirAnimationWidget的实现,确保在contentWidget为空时能够正确处理动画逻辑。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, Lighto-Ku

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs Johnson-zs merged commit e7d5038 into linuxdeepin:develop/snipe-tmp Aug 16, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants