Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacotr: Using raw pointers instead of smart pointers in extension m… #2209

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Johnson-zs
Copy link
Contributor

…odules

External plugins may manage memory on their own, which may result in double free here

Log: fix coredump

…odules

External plugins may manage memory on their own, which may result in double free here

Log: fix coredump
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • EmblemIconWorker类的parseLocationEmblemIconsparseEmblemIcons方法中,将QSharedPointer<DFMEXT::DFMExtEmblemIconPlugin>更改为DFMEXT::DFMExtEmblemIconPlugin *,可能会导致内存泄漏或未正确释放资源的问题。
  • ExtensionPluginManager类的menuPluginsemblemPluginswindowPlugins方法中,将QList<QSharedPointer<DFMEXT::DFMExtMenuPlugin>>QList<QSharedPointer<DFMEXT::DFMExtEmblemIconPlugin>>QList<QSharedPointer<DFMEXT::DFMExtWindowPlugin>>更改为QList<DFMEXT::DFMExtMenuPlugin *>QList<DFMEXT::DFMExtEmblemIconPlugin *>QList<DFMEXT::DFMExtWindowPlugin *>,需要确保这些指针在不再需要时被正确释放。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs Johnson-zs merged commit e47de28 into linuxdeepin:master Aug 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants