Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ulnfs] change dlnfs to ulnfs #2210

Conversation

pppanghu77
Copy link
Contributor

[ulnfs] change dlnfs to ulnfs

Log: [ulnfs] change dlnfs to ulnfs

[ulnfs] change dlnfs to ulnfs

Log: [ulnfs] change dlnfs to ulnfs
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • UlnfsMountHelper类中,loadKernelModulecheckLnfsExistisModuleLoaded方法可能需要更详细的错误处理和日志记录。
  • parseErrorCodeByMsg方法中的res参数没有在方法体内使用,可能是一个遗漏。
  • mount方法中,aPath变量被声明但未在后续代码中使用,应该检查是否遗漏了相关的逻辑。
  • mount方法中,fmInfo()fmWarning()调用可能需要根据实际日志级别进行调整。
  • unmount方法中,modprobeProcess.waitForFinished()调用可能需要检查进程是否成功完成,以避免潜在的资源泄露。

是否建议立即修改:

Copy link

[Debian检查]
检测到debian目录文件有变更: debian/dde-file-manager.install

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max-lvs, pppanghu77

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pppanghu77
Copy link
Contributor Author

merge

@pppanghu77
Copy link
Contributor Author

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

This pr cannot be merged! (status: unstable)

@max-lvs max-lvs merged commit 10aaf1b into linuxdeepin:develop/eagle-1070u2-ulnfs Aug 30, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants