Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dde-file-manager crash, search crash #2218

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

liyigang1
Copy link
Contributor

if window not exists, don't send sendStopSpinner event

Log: dde-file-manager crash, search crash
Bug: https://pms.uniontech.com/task-view-358757.html

if window not exists, don't send sendStopSpinner event

Log: dde-file-manager crash, search crash
Bug: https://pms.uniontech.com/task-view-358757.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CrumbInterface::onUpdateChildren方法中,直接使用child.fileName()替换了info->nameOf(NameInfoType::kFileName),可能会导致文件名编码问题。建议检查child.fileName()的实现是否能够正确处理不同编码的文件名。
  • SearchEventCaller::sendStopSpinner方法中,增加了对窗口ID的检查,以确保发送的信号仅针对存在的窗口。这是一个好的做法,可以避免潜在的崩溃问题。

是否建议立即修改:

  • 是,建议立即修改CrumbInterface::onUpdateChildren方法中的文件名编码问题,以确保代码的健壮性和跨平台兼容性。
  • 是,建议立即修改SearchEventCaller::sendStopSpinner方法中的窗口检查逻辑,以确保代码的健壮性和性能。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit 66e64a7 into linuxdeepin:master Aug 22, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants