Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dde-file-mananger crash, switch show mode #2232

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

liyigang1
Copy link
Contributor

dde-file-mananger crash, switch show mode

Log: dde-file-mananger crash, switch show mode

dde-file-mananger crash, switch show mode

Log: dde-file-mananger crash, switch show mode
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FileView::setViewMode函数中,d->delegates[static_cast<int>(Global::ViewMode::kListMode)]->setPaintProxy(new ListItemPaintProxy(this));被重复调用,应该移除重复代码。
  • setIconSize函数被调用两次,应该移除不必要的调用。
  • viewport()->setContentsMargins(0,0,0,0);setViewMode函数中被调用,但在kExtendModekTreeMode的情况下没有设置任何代理,可能会导致未定义的行为。
  • setListViewMode函数在kAllViewMode情况下被调用,但在代码更改前已经调用了setListViewMode,这可能是不必要的。
  • ListItemDelegate::getRectOfItem函数中,对d->paintProxy的存在性进行了检查,但是没有处理d->paintProxynullptr的情况,可能会导致空指针解引用。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs Johnson-zs merged commit ad0acf8 into linuxdeepin:master Aug 28, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants