Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Paste file event report #2236

Merged
merged 1 commit into from
Aug 29, 2024
Merged

feat: Paste file event report #2236

merged 1 commit into from
Aug 29, 2024

Conversation

liyigang1
Copy link
Contributor

Add dbus call, add group policy, and execute dbus call after copying and cutting ends

Log: Paste file event report
Task: https://pms.uniontech.com/task-view-359667.html

Add dbus call, add group policy, and execute dbus call after copying and cutting ends

Log: Paste file event report
Task: https://pms.uniontech.com/task-view-359667.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • boardCastPastData函数中,应该检查fileMonitor.isValid()以确保fileMonitor对象是有效的,然后再调用asyncCallWithArgumentList方法。
  • boardCastPastData函数中的data变量应该使用QVariantQVariant::fromValue方法来构造,而不是直接使用append方法。
  • boardCastPastData函数中的fileNames变量应该使用QStringListjoin方法来构造字符串,而不是直接连接。
  • canBroadcastPaste函数中,应该检查DConfigManager::instance()->value的返回值是否是有效的,然后再进行类型转换。
  • canBroadcastPaste函数的命名应该更清晰地表达其功能,例如canBroadcastPasteEvent

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit ad490e6 into linuxdeepin:master Aug 29, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants