Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create new text in the SMB server, double-click to open the text editor and edit the text #2246

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

liyigang1
Copy link
Contributor

The mimetype method for reading files is inconsistent, and the parameters passed in using openwithdialog are incorrect

Log: Create new text in the SMB server, double-click to open the text editor and edit the text
Bug: https://pms.uniontech.com/bug-view-267705.html

… editor and edit the text

The mimetype method for reading files is inconsistent, and the parameters passed in using openwithdialog are incorrect

Log: Create new text in the SMB server, double-click to open the text editor and edit the text
Bug: https://pms.uniontech.com/bug-view-267705.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在代码更改中,fileHandler.getInvalidPath()被替换为urls,需要确认urls是否已经定义并且具有正确的格式。
  • 检查dpfSlotChannel->push函数是否能够处理不同类型的参数,以及是否需要对参数进行类型检查。

是否建议立即修改:

  • 是,需要确保参数的正确性和函数的健壮性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs Johnson-zs merged commit 5a000ed into linuxdeepin:master Sep 3, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants