Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [desktop] the view setting dialog lost focus #2251

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Sep 3, 2024

as title.

Log: as title.

Bug: https://pms.uniontech.com/bug-view-271953.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在代码注释中提到了“ requiring widget to be visible when layout calculates sizehint.”,但实际代码中移除了这行设置,可能会影响布局计算。
  • 注释中提到的“ Commenting this line seems to have no effect”可能需要更详细的解释,或者提供更多的上下文来理解为什么这一行注释没有效果。

是否建议立即修改:

  • 是,需要确认移除wid->setVisible(true);这行代码是否会影响布局计算,如果移除是有意为之,则需要确保这一改动不会对程序功能产生负面影响。
  • 是,如果注释中的“ Commenting this line seems to have no effect”是正确的,那么应该提供更多的信息来解释为什么这一行代码没有效果,或者撤销这一行注释,以保持代码的完整性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs Johnson-zs merged commit 8fa8b9d into linuxdeepin:release/eagle Sep 3, 2024
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants