Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Local directory attribute box statistics file size and quantity errors #2253

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

liyigang1
Copy link
Contributor

Local directory attribute box statistics file size and quantity errors

Log: Local directory attribute box statistics file size and quantity errors

…errors

Local directory attribute box statistics file size and quantity errors

Log: Local directory attribute box statistics file size and quantity errors
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • SyncFileInfoPrivate::updateFileType()函数中,移除了对fileMode的赋值操作,可能会影响后续代码逻辑。需要确认这一改动是否符合预期。
  • BasicWidget::basicFill()函数中,增加了对fileCalculationUtils的连接操作,但没有相应的注释说明连接的目的和作用。

是否建议立即修改:

  • 是,需要确认SyncFileInfoPrivate::updateFileType()函数中移除fileMode赋值操作的合理性,并添加必要的注释。
  • 是,建议添加注释来解释fileCalculationUtils连接操作的目的和作用,以便其他开发者理解代码的意图。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs Johnson-zs merged commit 3de5926 into linuxdeepin:release/eagle Sep 3, 2024
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants