Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Open multiple trash windows, window A enters the trash folder, window B deletes or restores the folder, window A returns to the computer path #2266

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

liyigang1
Copy link
Contributor

Add hook event to determine whether to jump to the computer interface

Log: Open multiple trash windows, window A enters the trash folder, window B deletes or restores the folder, window A returns to the computer path
Bug: https://pms.uniontech.com/bug-view-270855.html

…indow B deletes or restores the folder, window A returns to the computer path

Add hook event to determine whether to jump to the computer interface

Log: Open multiple trash windows, window A enters the trash folder, window B deletes or restores the folder, window A returns to the computer path
Bug: https://pms.uniontech.com/bug-view-270855.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • handleNotCdComputer函数中,cdUrl参数被初始化为nullptr,但在后续的代码中没有检查这个指针是否为nullptr
  • handleNotCdComputer函数中,当url.scheme()不等于scheme()时,直接返回false,这可能意味着在处理特定的协议或模式时,函数的实现不够完整。
  • handleNotCdComputer函数中,如果cdUrl指针不为nullptr,则将其设置为回收站的根URL。这个操作假设了cdUrl总是指向有效的URL对象,并且在处理hook_Tab_FileDeleteNotCdComputer事件时,不会检查这个假设。
  • handleNotCdComputer函数中,如果cdUrl指针为nullptr,则将其设置为kGotoWhenDevRemoved。这个操作假设了当cdUrlnullptr时,总是需要跳转到设备移除路径。这个假设可能不总是成立,应该根据实际的需求进行调整。
  • handleNotCdComputer函数中,如果url.scheme()等于Global::Scheme::kFile,则执行特定的操作,但是没有提供这些操作的实现。这可能意味着在处理特定的协议或模式时,函数的实现不够完整。
  • closeTab函数中,当url.scheme()等于Global::Scheme::kFile时,会执行特定的操作,但是没有提供这些操作的实现。这可能意味着在处理特定的协议或模式时,函数的实现不够完整。

是否建议立即修改:

@max-lvs max-lvs merged commit 3a294e4 into linuxdeepin:release/eagle Sep 5, 2024
26 of 28 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants