Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The problem of incorrect scrollbars in the content area when adjusting the window size in grid view #2278

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

liyigang1
Copy link
Contributor

When adjusting the window size, I kept increasing the contentsize

Log: The problem of incorrect scrollbars in the content area when adjusting the window size in grid view
Bug: https://pms.uniontech.com/bug-view-253883.html

…usting the window size in grid view

When adjusting the window size, I kept increasing the contentsize

Log: The problem of incorrect scrollbars in the content area when adjusting the window size in grid view
Bug: https://pms.uniontech.com/bug-view-253883.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FileView::resizeEvent中新增了d->isResizeEvent = true;d->isResizeEvent = false;,但未提供修改后的上下文信息,可能会导致混淆。
  • FileView::updateGeometries中增加了对d->isResizeEvent的检查,但未解释为什么需要这个检查。
  • FileViewPrivate类新增了isResizeEventlastContentHeight成员变量,但未提供这些变量的用途和修改的上下文信息。

是否建议立即修改:

  • 是,建议提供修改的上下文信息,以便其他开发者理解这些更改的目的和影响。同时,应该检查是否有必要进行这样的更改,以确保代码的清晰性和效率。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1
Copy link
Contributor Author

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 12, 2024

This pr cannot be merged! (status: unstable)

@liyigang1
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 12, 2024

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 1954719 into linuxdeepin:release/eagle Sep 12, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants