Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Customize menu] Customize menu merging #2298

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

pppanghu77
Copy link
Contributor

Merge menus with the same name

Log: [Customize menu] Customize menu merging
Task: https://pms.uniontech.com/task-view-363005.html

Merge menus with the same name

Log: [Customize menu] Customize menu merging
Task: https://pms.uniontech.com/task-view-363005.html
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, pppanghu77

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • isExist变量赋值后没有使用else语句,可能导致isExist始终为false
  • for (QAction *subaction : action->menu()->actions())循环中没有检查subaction是否为nullptr,可能会导致空指针解引用。
  • existAction->menu()->addAction(subaction)调用可能需要检查existAction->menu()是否为nullptr
  • d->cacheActionsSeparator.insert(action, actionData.separator())调用可能需要检查actionData.separator()是否为有效的分隔符值。
  • actionData.separator()的定义未在代码片段中显示,需要确认其有效值范围。

是否建议立即修改:

@pppanghu77
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 4d89a6e into linuxdeepin:release/eagle Sep 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants