Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs #2299

Merged
merged 3 commits into from
Sep 20, 2024
Merged

fix bugs #2299

merged 3 commits into from
Sep 20, 2024

Conversation

Johnson-zs
Copy link
Contributor

No description provided.

`com.deepin.filemanager.vault.policy` is polkit policy name, isn't DBus name

log: fix bug

bug: https://pms.uniontech.com/bug-view-273547.html
`qApp->quit` causes the main thread to block

Log: fix filemanager freezing

Bug: https://pms.uniontech.com/bug-view-272373.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • SingleApplication::handleQuitAction()函数中,直接调用qApp->quit()可能会导致未处理的退出逻辑。建议使用一个退出信号或事件处理函数来处理应用程序的退出。
  • WindowUtils::closeAllFileManagerWindows()函数中,直接关闭所有窗口可能会导致用户未保存的工作丢失。建议提供一种机制来保存现有工作,或者在关闭窗口之前提示用户。
  • kPolkitVaultCreatekPolkitVaultRemove常量中的字符串已从org.deepin.Filemanager.VaultManager更改为com.deepin.filemanager.daemon.VaultManager,需要确认这是否符合预期的D-Bus命名空间更改。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 20, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit b14350e into linuxdeepin:master Sep 20, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants