Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The application name on the dde-desktop cannot be renamed #2302

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

liyigang1
Copy link
Contributor

Desktop files on the desktop are hard linked and can be renamed based on whether the file is writable

Log: The application name on the dde-desktop cannot be renamed
Bug: https://pms.uniontech.com/bug-view-256967.html

Copy link
Contributor

@Johnson-zs Johnson-zs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abled?

Desktop files on the desktop are hard linked and can be renamed based on whether the file is writable

Log: The application name on the dde-desktop cannot be renamed
Bug: https://pms.uniontech.com/bug-view-256967.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • DesktopFileInfo::canAttributes函数中新增的代码块可能会导致ProxyFileInfo::canAttributes的调用被覆盖,应该检查ProxyFileInfo::canAttributes的返回值。
  • FileOperatorMenuScene::initialize函数中的条件判断逻辑可能存在逻辑错误,应该先判断d->focusFileInfo是否为空,再进行其他操作。
  • CanvasMenuScenePrivate::filterDisableAction函数中的renameEnabled变量应该声明为bool类型,而不是true
  • WorkspaceMenuScene::updateState函数中的条件判断逻辑可能存在逻辑错误,应该先判断d->focusFileInfo是否为空,再进行其他操作。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 20, 2024

This pr force merged! (status: behind)

@deepin-bot deepin-bot bot merged commit 77ced98 into linuxdeepin:master Sep 20, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants