Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cmd] cannot open url in cmd if plugin is lazy loaded. #2303

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Sep 20, 2024

as above.

Log: as above.

Bug: https://pms.uniontech.com/bug-view-273805.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • openWindowWithUrl函数中,使用了Q_ASSERT宏,这可能会导致未定义行为,应该避免使用或者替换为更安全的检查。
  • openWindowWithUrl函数中的schemeMapschemePlugins的初始化应该放在dpf::LifeCycle::pluginMetaObjs回调函数之外,以避免潜在的初始化顺序问题。
  • openWindowWithUrl函数中的std::call_once的使用可能会导致线程安全问题,应该确保dpfSignalDispatcher->publish的调用是线程安全的。
  • DConfigManager::instance()->value的调用使用了kOpenFolderWindowsInASeparateProcess,但是没有提供这个键的定义,应该确保键的定义是正确的。
  • trash.jsonsmbbrowser.json文件中的PluginSchemes字段被更新,但是没有提供这些更新后的值的来源,应该确保这些更改是正确的。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 20, 2024

This pr force merged! (status: behind)

@deepin-bot deepin-bot bot merged commit 83d3c8f into linuxdeepin:master Sep 20, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants