Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [ulnfs] Prioritize the mounting method for long file names #2314

Conversation

pppanghu77
Copy link
Contributor

Do not mount dlnfs while enabling ulnfs

Log: [ulnfs] Prioritize the mounting method for long file names
Task: https://pms.uniontech.com/task-view-359649.html

Do not mount dlnfs while enabling ulnfs

Log: [ulnfs] Prioritize the mounting method for long file names
Task: https://pms.uniontech.com/task-view-359649.html
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pppanghu77

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的代码中,变量 ulnfs_enable 的赋值方式可能会导致歧义,建议使用 = 而不是 == 来赋值。
  • 条件判断中使用了两个连续的 && 操作符,这可能会导致逻辑错误,建议使用 -a 或者 -o 操作符来组合多个条件。
  • 新增的代码中没有处理 ulnfs_enabletrue 的情况,如果需要同时检查 dlnfs_enableulnfs_enable,应该添加相应的逻辑。

是否建议立即修改:

@pppanghu77 pppanghu77 closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants