Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [burn] dvd+rw cannot be closed. #2319

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Sep 26, 2024

hide the "allow append" checkbox.

Log: as above.

Bug: https://pms.uniontech.com/bug-view-265293.html

hide the "allow append" checkbox.

Log: as above.

Bug: https://pms.uniontech.com/bug-view-265293.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • setMediaType函数中,应该检查media变量是否为DFMBURN::MediaType::kDVD_PLUS_RW,而不是直接比较字符串。
  • setMediaType函数的实现应该考虑在mediaDFMBURN::MediaType::kDVD_PLUS_RW时隐藏donotcloseComb,但在其他情况下不隐藏。
  • setMediaType函数的实现应该添加注释说明其功能和预期的media值。
  • setMediaType函数的实现应该检查media变量是否为有效的DFMBURN::MediaType枚举值,以避免潜在的未定义行为。

是否建议立即修改:

Copy link

  • 敏感词检查失败, 检测到49个文件存在敏感词
详情
{
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/README.zh_CN.md": [
        {
            "line": "$ git clone https://github.com/linuxdeepin/dde-file-manager",
            "line_number": 62,
            "rule": "S35",
            "reason": "Url link | 8518c44915"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/README.md": [
        {
            "line": "$ git clone https://github.com/linuxdeepin/dde-file-manager",
            "line_number": 62,
            "rule": "S35",
            "reason": "Url link | 8518c44915"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/.clog.toml": [
        {
            "line": "repository = \"https://github.com/linuxdeepin/dde-file-manager\"",
            "line_number": 2,
            "rule": "S35",
            "reason": "Url link | 8518c44915"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/desktop/ddplugin-background/background.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/desktop/ddplugin-organizer/organizerplugin.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 21,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/desktop/ddplugin-wallpapersetting/wallpapersetting.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/desktop/core/ddplugin-canvas/canvas.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/desktop/core/ddplugin-core/core.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/dfmplugin-avfsbrowser/avfsbrowser.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/dfmplugin-smbbrowser/smbbrowser.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/dfmplugin-search/search.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/dfmplugin-vault/vault.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/dfmplugin-vault/views/unlockview/retrievepasswordview.cpp": [
        {
            "line": "const QString PolicyKitRetrievePasswordActionId = \"com.deepin.filemanager.vault.VerifyKey.RetrievePassword\";",
            "line_number": 36,
            "rule": "S105",
            "reason": "Entropy+Var naming | 14148000f8"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/dfmplugin-optical/optical.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/core/dfmplugin-trash/trash.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/core/dfmplugin-titlebar/titlebar.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/core/dfmplugin-workspace/workspace.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/core/dfmplugin-sidebar/sidebar.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/core/dfmplugin-detailspace/detailspace.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/core/dfmplugin-computer/computer.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/core/dfmplugin-recent/recent.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/core/dfmplugin-core/core.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filemanager/dfmplugin-myshares/myshares.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/filedialog/filedialogplugin-core/core.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/server/serverplugin-vaultdaemon/vaultcontrol.cpp": [
        {
            "line": "        const QString &passwd = passwordFromKeyring();",
            "line_number": 99,
            "rule": "S28",
            "reason": "Suspicious password declaration | bbb03f3741"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/dfmplugin-dirshare/dirshare.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/dfmplugin-burn/burn.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/dfmplugin-utils/utils.json": [
        {
            "line": "            \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 16,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        },
        {
            "line": "            \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 30,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        },
        {
            "line": "            \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 44,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        },
        {
            "line": "            \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 58,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        },
        {
            "line": "            \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 72,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        },
        {
            "line": "            \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 86,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        },
        {
            "line": "            \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 100,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        },
        {
            "line": "            \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 114,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/dfmplugin-emblem/emblem.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/dfmplugin-preview/pluginpreviews/dciicon-preview/dtk-dci.xml": [
        {
            "line": "<mime-info xmlns=\"http://www.freedesktop.org/standards/shared-mime-info\">",
            "line_number": 2,
            "rule": "S35",
            "reason": "Url link | 4072667606"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/dfmplugin-preview/filepreview/filepreview.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/core/dfmplugin-menu/menu.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/core/dfmplugin-propertydialog/propertydialog.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/core/dfmplugin-fileoperations/fileoperations.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 21,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/core/dfmplugin-fileoperations/fileoperationsevent/fileoperationseventreceiver.cpp": [
        {
            "line": "            key = \"Name\";",
            "line_number": 364,
            "rule": "S106",
            "reason": "Var naming | ff5dbee3ee"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/core/dfmplugin-bookmark/bookmark.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/core/dfmplugin-trashcore/trashcore.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/common/dfmplugin-tag/tag.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/daemon/daemonplugin-accesscontrol/accesscontrol.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/daemon/daemonplugin-sharecontrol/sharecontrol.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/daemon/core/daemonplugin-core/core.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/daemon/daemonplugin-anything/anything.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/plugins/daemon/daemonplugin-mountcontrol/mountcontrol.json": [
        {
            "line": "    \"UrlLink\" : \"https://www.uniontech.com\",",
            "line_number": 11,
            "rule": "S35",
            "reason": "Url link | 3c9a9fccb6"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/src/apps/dde-file-manager/main.cpp": [
        {
            "line": "    a.setApplicationAcknowledgementPage(\"https://www.deepin.org/acknowledgments/\" + qApp->applicationName());",
            "line_number": 292,
            "rule": "S35",
            "reason": "Url link | e56e98a089"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/debian/control": [
        {
            "line": "Homepage: http://www.deepin.org",
            "line_number": 49,
            "rule": "S35",
            "reason": "Url link | 6fe814dfb7"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/tests/plugins/desktop/ddplugin-organizer/config/ut_configpresenter.cpp": [
        {
            "line": "        ptr->key = \"temp_key\";",
            "line_number": 31,
            "rule": "S106",
            "reason": "Var naming | 49e49b965e"
        },
        {
            "line": "    style.key = \"temp_key\";",
            "line_number": 67,
            "rule": "S106",
            "reason": "Var naming | 49e49b965e"
        }
    ],
    "/home/runner/work/dde-file-manager/dde-file-manager/sourceCode/tests/plugins/desktop/ddplugin-organizer/mode/ut_custommode.cpp": [
        {
            "line": "    QString key = \"temp_key\";",
            "line_number": 91,
            "rule": "S106",
            "reason": "Var naming | 49e49b965e"
        }
    ]
}

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs
Copy link
Contributor

/merge

@deepin-bot deepin-bot bot merged commit da94b41 into linuxdeepin:release/eagle Sep 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants