Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manual treeland adaptation #487

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

pengfeixx
Copy link
Contributor

manual treeland adaptation

Log: manual treeland adaptation

Copy link

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@jeffshuai
Copy link

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

manual treeland adaptation

Log: manual treeland adaptation
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Utils::judgeTreeLand函数中,qEnvironmentVariable的调用应该在if语句之前添加QString类型的转换,以确保变量值被正确处理。
  • Utils::getMdsourcePath函数中,返回的QStringList应该包含一个空字符串作为分隔符,以便在输出时正确显示路径。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 7a8a003 into linuxdeepin:master Aug 20, 2024
17 checks passed
@pengfeixx pengfeixx deleted the treeland branch August 20, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants