Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the issue of manual. open dbus service response timeout #490

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Aug 30, 2024

Fix the issue of manual. open dbus service response timeout

Log: Fix the issue of manual. open dbus service response timeout
Bug: https://pms.uniontech.com/bug-view-269561.html

  Fix the issue of manual. open dbus service response timeout

Log: Fix the issue of manual. open dbus service response timeout
Bug: https://pms.uniontech.com/bug-view-269561.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • debian/deepin-manual.postinst文件中,使用了bash作为脚本解释器,但脚本中的命令runuser可能无法在sh脚本中执行。建议使用兼容的脚本解释器,如bash
  • for循环中,userNameArr变量被赋值给userName,可能导致变量名称冲突。建议重新命名变量以避免混淆。
  • runuser命令的错误处理使用了|| true,这可能会隐藏脚本执行中的错误。建议使用更具体的错误处理方式,如|| false
  • systemctl --user daemon-reload命令可能需要根据实际需求调整,例如,如果后端定时任务不需要在每个用户登录时重新加载,则不需要执行此操作。
  • misc/deepin-manual.service文件中,CapabilityBoundingSet的值被设置为~,这可能会导致服务拥有过多权限,应根据实际需求调整。

是否建议立即修改:

@pengfeixx
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@starhcq starhcq merged commit f5033d2 into linuxdeepin:master Sep 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants