Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cmd] Remove command line calls through shell parsing #492

Closed
wants to merge 1 commit into from

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Sep 5, 2024

Remove command line calls through shell parsing

Log: Remove command line calls through shell parsing
Task: https://pms.uniontech.com/task-view-355359.html

    Remove command line calls through shell parsing

Log: Remove command line calls through shell parsing
Task: https://pms.uniontech.com/task-view-355359.html
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq closed this Sep 6, 2024
@starhcq starhcq reopened this Sep 6, 2024
@starhcq starhcq changed the base branch from release/1071 to release/eagle September 6, 2024 07:08
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • RunScriptFile函数中,使用QStringList来构建命令参数,这是一个好的做法,因为它提供了更好的类型安全。
  • SpawnCmd函数中,添加了对命令参数的检查,这是一个改进,因为它避免了潜在的错误。
  • shellObjexecSystem方法中,添加了对命令参数的传递,这是一个必要的改进,因为它允许外部命令接受参数。
  • DManWatcherexecutCmd方法中,使用QStringList来传递命令参数,这是一个好的实践,因为它提供了更好的类型安全。

是否建议立即修改:

  • 是,因为这些修改提高了代码的可读性、可维护性和安全性。特别是对于RunScriptFileSpawnCmd的改进,应该立即采纳,因为它们修复了潜在的错误和提高的代码质量。
  • 对于shellObjDManWatcher的改进,建议在下一个合适的版本中采纳,因为它们引入了新的功能,但没有紧急的错误需要修复。

@starhcq starhcq closed this Sep 6, 2024
@starhcq starhcq deleted the release/1071 branch September 6, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants