Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cmd] Remove command line calls through shell parsing #493

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Sep 6, 2024

Remove command line calls through shell parsing

Log: Remove command line calls through shell parsing
Task: https://pms.uniontech.com/task-view-355359.html

src/controller/shellobj.h Outdated Show resolved Hide resolved
    Remove command line calls through shell parsing

Log: Remove command line calls through shell parsing
Task: https://pms.uniontech.com/task-view-355359.html
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • RunScriptFile函数中,使用QStringList来构建命令参数,这是一个好的做法,因为它提供了更好的类型安全。
  • SpawnCmd函数中,添加了对命令参数的检查,这是一个改进,因为它避免了潜在的错误。
  • shellObj类中,将cmd属性更改为m_cmd,这是一个改进,因为它提高了代码的可读性和一致性。
  • DManWatcher类中,使用QStringList来传递命令参数,这是一个改进,因为它提供了更好的类型安全。

是否建议立即修改:

  • 是,这些修改提高了代码的可读性、可维护性和健壮性,应该立即采纳。

@starhcq starhcq merged commit 26b2ec1 into linuxdeepin:release/eagle Sep 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants