Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复在帮助手册打开后,再次打开帮助手册崩溃 #494

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

myk1343
Copy link

@myk1343 myk1343 commented Sep 10, 2024

修复在帮助手册打开后,再次打开帮助手册崩溃

Bug: https://pms.uniontech.com/bug-view-271185.html
https://pms.uniontech.com/bug-view-268377.html
Log: 修复在帮助手册打开后,再次打开帮助手册崩溃

修复在帮助手册打开后,再次打开帮助手册崩溃

Bug: https://pms.uniontech.com/bug-view-271185.html
https://pms.uniontech.com/bug-view-268377.html
Log: 修复在帮助手册打开后,再次打开帮助手册崩溃
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了WindowManager的实例化代码,但未移除window_manager的声明,可能会导致未定义的变量错误。
  • 信号与槽的连接被移动到了argument_parser.openManualsDelay()函数之后,但没有提供原始连接的上下文。
  • 删除了setStartTimebindSignalSlot的调用,但没有提供这些调用的替代逻辑或解释为什么它们不再需要。

是否建议立即修改:

@jeffshuai
Copy link

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343
Copy link
Author

myk1343 commented Sep 11, 2024

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 11, 2024

This pr cannot be merged! (status: unstable)

@pengfeixx pengfeixx merged commit eff0bb6 into linuxdeepin:release/eagle Sep 11, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants