Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 调整相机初始化和修复剪贴板无数据问题 #483

Merged
merged 2 commits into from
May 9, 2024

Conversation

rb-union
Copy link
Contributor

@rb-union rb-union commented May 8, 2024

相机调整为在录屏时初始化,截图时无需调用

Log: 调整应用初始化处理

旧版保存了图片的原始数据,在数据较大时对后端
剪贴板有影响。调整为使用转换PNG格式数据,降低
后端转换影响。

Log: 修改剪贴板无记录问题
Bug: https://pms.uniontech.com/bug-view-251565.html

相机调整为在录屏时初始化,截图时无需调用

Log: 调整应用初始化处理
旧版保存了图片的原始数据,在数据较大时对后端
剪贴板有影响。调整为使用转换PNG格式数据,降低
后端转换影响。

Log: 修改剪贴板无记录问题
Bug: https://pms.uniontech.com/bug-view-251565.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • MainWindow::save2Clipboard函数中,修改了图片保存格式为"PNG",这是一个功能变更,需要确认是否与产品需求一致。
  • MainWindow::saveImg函数中,也进行了类似的图片保存格式更改,但未见相应的功能说明或需求变更。

是否建议立即修改:

  • 是,如果这个功能变更没有得到充分讨论和文档更新,应立即进行审查和确认。如果这个变更是根据产品的需求变更来执行的,那么可以保留这个更改。如果这个更改是无意的或者不满足需求的,应该立即撤销。

@myk1343
Copy link
Contributor

myk1343 commented May 9, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union
Copy link
Contributor Author

rb-union commented May 9, 2024

/merge

@deepin-bot deepin-bot bot merged commit c5602de into linuxdeepin:release/eagle May 9, 2024
7 checks passed
@rb-union rb-union deleted the fix-251565 branch May 9, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants