Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blurry screen of video recorded error #487

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

add-uos
Copy link
Contributor

@add-uos add-uos commented Jun 7, 2024

fix the blurry screen of video recorded by a wayland machine

Log: fix the blurry screen of video recorded by a wayland machine

Bug: https://pms.uniontech.com/bug-view-249005.html

fix the blurry screen of video recorded by a wayland machine

Log: fix the blurry screen of video recorded by a wayland machine

Bug: https://pms.uniontech.com/bug-view-249005.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中移除了#ifdef KWAYLAND_REMOTE_BUFFER_RELEASE_FLAGE_ON的宏定义,但没有提供相应的替代逻辑或解释为什么需要移除。
  • 移除了处理远程缓冲区释放的代码,可能会影响远程缓冲区的管理,需要确认这一改动是否符合设计需求。
  • 新增了munmap(mapData, stride * height);的调用,但未看到对应的数据结构或变量mapData的定义,可能会导致编译错误。
  • 删除了qDebug()qWarning()的日志输出,如果这些输出对于调试和错误追踪至关重要,应该保留这些输出。

是否建议立即修改:

  • 是,需要提供对移除代码块的解释,并确保不会对现有的功能产生负面影响。
  • 是,如果移除远程缓冲区释放代码会影响到远程缓冲区的管理功能,应该立即恢复或提供替代的实现方案。
  • 是,需要验证mapData变量的定义是否正确,并确保munmap的调用不会导致程序崩溃。
  • 是,如果移除日志输出会影响调试和错误追踪,应该立即恢复或提供替代的日志记录方案。

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@add-uos
Copy link
Contributor Author

add-uos commented Jun 7, 2024

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 7, 2024

This pr cannot be merged! (status: blocked)

@add-uos
Copy link
Contributor Author

add-uos commented Jun 7, 2024

/merge

@deepin-bot deepin-bot bot merged commit a427559 into linuxdeepin:release/eagle Jun 7, 2024
7 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants