Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 贴图不能移动出屏幕 #489

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

add-uos
Copy link
Contributor

@add-uos add-uos commented Jun 13, 2024

截屏贴图-触发贴图后滑动鼠标滚轮缩放,窗口不能超出屏幕

Log: 截屏贴图-触发贴图后滑动鼠标滚轮缩放,窗口不能超出屏幕
Bug: https://pms.uniontech.com/bug-view-254799.html

截屏贴图-触发贴图后滑动鼠标滚轮缩放,窗口不能超出屏幕

Log:  截屏贴图-触发贴图后滑动鼠标滚轮缩放,窗口不能超出屏幕
Bug: https://pms.uniontech.com/bug-view-254799.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • MainWindow::initMainWindow函数中添加了Qt::BypassWindowManagerHint标志,需要确认这是否是预期的行为。
  • mouseMoveEvent函数中移除了对Wayland模式的处理,需要确认这是否是有意为之。

是否建议立即修改:

  • 是,需要确认添加Qt::BypassWindowManagerHint是否符合产品需求和用户体验。
  • 是,如果移除对Wayland模式的处理是故意的,应该添加相应的注释说明原因。如果这是一个错误,应该恢复这部分代码。

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@add-uos
Copy link
Contributor Author

add-uos commented Jun 13, 2024

/merge

@deepin-bot deepin-bot bot merged commit 90188ed into linuxdeepin:release/eagle Jun 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants