Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust the time sequence of the screenshot completion prompt #510

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

lzwind
Copy link
Contributor

@lzwind lzwind commented Jul 26, 2024

Adjust the time sequence of the screenshot completion prompt

Log: Adjust the time sequence of the screenshot completion prompt
Bug: https://pms.uniontech.com/bug-view-266109.html

Adjust the time sequence of the screenshot completion prompt

Log: Adjust the time sequence of the screenshot completion prompt
Bug: https://pms.uniontech.com/bug-view-266109.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • MainWindow::initAttributes()函数中,代码格式化已经改进,例如缩进和空格的使用。
  • MainWindow::initAttributes()函数中,增加了对DSysInfo::minorVersion().toInt() >= 1070的判断,但未提供上下文说明为什么需要这个条件。
  • MainWindow::initAttributes()函数中,删除了对m_hasComposite的检查,但未提供上下文说明为什么需要删除这个检查。
  • MainWindow::initAttributes()函数中,删除了对m_isSaveClipboard的检查,但未提供上下文说明为什么需要删除这个检查。
  • MainWindow::checkIsLockScreen()函数中,删除了对m_isFullScreenRecord的检查,但未提供上下文说明为什么需要删除这个检查。
  • MainWindow::save2Clipboard()函数中,删除了对m_isFullScreenRecord的检查,但未提供上下文说明为什么需要删除这个检查。
  • MainWindow::save2Clipboard()函数中,删除了对m_isSaveClipboard的检查,但未提供上下文说明为什么需要删除这个检查。
  • MainWindow::updateToolBarPos()函数中,删除了对m_isFullScreenRecord的检查,但未提供上下文说明为什么需要删除这个检查。
  • MainWindow::getTwoScreenIntersectPos()函数中,删除了对m_isFullScreenRecord的检查,但未提供上下文说明为什么需要删除这个检查。
  • MainWindow::getTwoScreenIntersectPos()函数中,删除了对m_isSaveClipboard的检查,但未提供上下文说明为什么需要删除这个检查。
  • MainWindow::getTwoScreenIntersectPos()函数中,删除了对m_hasComposite的检查,但未提供上下文说明为什么需要删除这个检查。
  • MainWindow::paintEvent()函数中,删除了对m_isFullScreenRecord的检查,但未提供上下文说明为什么需要删除这个检查。
  • MainWindow::stopRecord()函数中,删除了对m_isFullScreenRecord的检查,但未提供上下文说明为什么需要删除这个检查。

是否建议立即修改:

  • 需要提供对代码中修改的上下文说明,以便其他开发者理解这些更改的原因和影响。
  • 应该避免在代码中添加未解释的逻辑判断,因为这可能会使代码难以理解和维护。

Copy link

@wyu71 wyu71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
Copy link
Contributor Author

lzwind commented Jul 26, 2024

/merge

@deepin-bot deepin-bot bot merged commit 09772f6 into linuxdeepin:release/eagle Jul 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants