Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust the time sequence of the screenshot completion prompt #517

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

lzwind
Copy link
Contributor

@lzwind lzwind commented Aug 5, 2024

Adjust the time sequence of the screenshot completion prompt

Log: Adjust the time sequence of the screenshot completion prompt
Bug: https://pms.uniontech.com/bug-view-266109.html

Adjust the time sequence of the screenshot completion prompt

Log: Adjust the time sequence of the screenshot completion prompt
Bug: https://pms.uniontech.com/bug-view-266109.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • MainWindow::initAttributes()函数中,代码格式化有所改进,例如缩进和空格的使用。
  • MainWindow::initScrollShot()函数中,对m_pixelRatio的计算进行了修正,确保了在不同屏幕分辨率下的正确性。
  • MainWindow::fullScreenRecord()函数中,增加了对exitApp()的调用,但未提供调用此函数的上下文,可能会导致未处理的退出行为。
  • MainWindow::save2Clipboard()函数中,增加了对exitApp()的调用,但同样未提供调用此函数的上下文。
  • MainWindow::sendNotify()函数中,增加了对exitApp()的调用,但同样未提供调用此函数的上下文。
  • MainWindow::saveScreenShot()函数中,增加了对exitApp()的调用,但同样未提供调用此函数的上下文。
  • MainWindow::stopRecord()函数中,增加了对sendSavingNotify()的调用,但同样未提供调用此函数的上下文。

是否建议立即修改:

这些修改主要是关于代码的格式化和一致性,以及确保了在不同的运行环境下正确地调用了exitApp()函数。然而,这些修改没有涉及到代码的功能性或逻辑性,因此不需要立即修改。但是,为了保持代码库的整洁和一致性,建议在下一个合适的迭代中合并这些修改。

Copy link

@wyu71 wyu71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
Copy link
Contributor Author

lzwind commented Aug 5, 2024

/merge

@deepin-bot deepin-bot bot merged commit cf034df into linuxdeepin:release/eagle Aug 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants