Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the status bar display error time #529

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

add-uos
Copy link
Contributor

@add-uos add-uos commented Aug 15, 2024

fix the status bar display error time

Log: fix the status bar display error time
Bug: https://pms.uniontech.com/bug-view-262791.html

@add-uos add-uos force-pushed the release/eagle branch 10 times, most recently from 514f882 to 3312320 Compare August 15, 2024 08:27
fix the status bar display error time

Log: fix the status bar display error time
Bug: https://pms.uniontech.com/bug-view-262791.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • RecordTimePlugin::clear()函数中,直接修改了m_timeWidget->setting()->setValue(),可能会导致与预期不符的行为,建议通过方法来修改配置。
  • TimeWidget::~TimeWidget()中,对m_setting的访问应该在m_setting不为nullptr的前提下进行,以避免潜在的空指针解引用错误。
  • TimeWidget::setting()函数中,返回的m_setting指针应该检查是否为nullptr,以避免在调用deleteLater()时出现未定义行为。
  • TimeWidget::paintEvent()中,qInfo()的调用应该在调试模式下使用,以避免生产环境中输出日志。
  • TimeWidget::start()函数中,m_baseTime的初始化应该在m_setting->value(RECORDER_TIME_STARTCONFIG).toTime()不为QTime(0,0,0)时进行,以避免未定义行为。
  • TimeWidget::stop()函数中,m_timerCount的初始化应该在m_setting->value(RECORDER_TIME_STARTCONFIG).toTime()不为QTime(0,0,0)时进行,以避免未定义行为。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@add-uos
Copy link
Contributor Author

add-uos commented Aug 15, 2024

/merge

@deepin-bot deepin-bot bot merged commit 0341935 into linuxdeepin:release/eagle Aug 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants