Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the dual screen expandsion position when scaled #550

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

add-uos
Copy link
Contributor

@add-uos add-uos commented Oct 14, 2024

fix the dual screen expandsion position when scaled

Log: fix the dual screen expandsion position when scaled
Bug: https://pms.uniontech.com/bug-view-273083.html

fix the dual screen expandsion position when scaled

Log: fix the dual screen expandsion position when scaled
Bug: https://pms.uniontech.com/bug-view-273083.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在获取环境变量时,应该检查环境变量是否存在,而不是直接使用 qgetenv
  • 使用 QDBusInterface 获取缩放因子时,应该处理可能的异常情况,例如 QDBusReply 的失败。
  • qDebug 应该在调试模式下使用,不应该在生产代码中留下调试信息。
  • 缩放因子的处理逻辑应该更加健壮,例如检查 QDBusReply 是否成功。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@add-uos
Copy link
Contributor Author

add-uos commented Oct 14, 2024

/merge

@deepin-bot deepin-bot bot merged commit 57d7d52 into linuxdeepin:release/eagle Oct 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants