Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [debugger] crash when debugging #1014

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

LiHua000
Copy link
Contributor

@LiHua000 LiHua000 commented Dec 6, 2024

Log: as title

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • StackFrameModelsetFrames函数中,currentIndex被硬编码为1,这可能不是预期的行为,应该检查是否应该初始化为0或其他逻辑值。
  • DebugManagerinitProcess函数中,connect语句的lambda表达式缺少this指针的上下文,应该明确指定d->process.data()作为上下文。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign eric2023 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 9ebd463 into linuxdeepin:master Dec 10, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants