Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [codegeex] optimized code generate logic #853

Closed
wants to merge 1 commit into from

Conversation

LiHua000
Copy link
Contributor

@LiHua000 LiHua000 commented Aug 1, 2024

Log: as title

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LiHua000
Once this PR has been reviewed and has the lgtm label, please assign toberyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CopilotApi::assembleGenerateBody函数中,将max_new_tokens的值从64增加到128,需要确认这是否符合API的预期限制。
  • CopilotApi::slotReadReply函数中,对code进行了截断处理,这可能会影响某些特定格式的代码。需要确保这种处理不会破坏代码的完整性和功能。

是否建议立即修改:

  • 是,需要确保max_new_tokens的更改不会导致API限制问题,并且截断代码的逻辑不会对现有功能产生负面影响。

@LiHua000 LiHua000 closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants