Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [project] debug/release switch issue #865

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

LiHua000
Copy link
Contributor

@LiHua000 LiHua000 commented Aug 6, 2024

Log: Support automatic switching of the application after toggling between debug/release compilation modes, and fix related bugs.

@LiHua000 LiHua000 force-pushed the master branch 2 times, most recently from c3719d6 to c0242fe Compare August 6, 2024 06:43
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign toberyan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Aug 7, 2024

TAG Bot

New tag: 1.3.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #867

Log: Support automatic switching of the application after toggling between debug/release compilation modes, and fix related bugs.
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CmakeProjectGenerator的构造函数中,直接使用dpfGetService(ProjectService)可能会导致循环依赖问题,建议使用依赖注入的方式来获取服务。
  • switchConfigType函数的实现没有考虑到tempSelTypedefaultType可能相等的情况,这可能会导致逻辑错误。
  • readConfig函数中,每次读取配置时都重新创建ProjectConfigure对象,这可能会导致不必要的性能开销。建议在需要时创建并使用配置对象。
  • saveConfig函数中,当tempSelTypedefaultType相等时,没有执行任何操作,这可能不是预期的行为。
  • getActiveProjectItem函数的实现依赖于treeView的实现,这增加了代码的耦合度。建议通过接口或依赖注入的方式来获取treeView的实例。
  • ProjectCoreReceivereventProcess函数中,直接访问project.activeProject.name,这可能会导致在project对象未初始化时访问其属性,这可能是一个潜在的错误。
  • ProjectTreegetActiveProjectItem函数中,直接使用d->itemModel->itemFromIndex(d->delegate->getActiveProject()),这假设了itemModeldelegate已经被正确初始化,这可能是一个潜在的错误。

是否建议立即修改:

@deepin-mozart deepin-mozart merged commit 6760172 into linuxdeepin:master Aug 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants