Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add scheme style with terminal #907

Closed
wants to merge 0 commits into from
Closed

refactor: add scheme style with terminal #907

wants to merge 0 commits into from

Conversation

Yurii-huang
Copy link
Contributor

  1. default use system deepin-terminal scheme
  2. not found deepin-terminal scheme, use qrc-file scheme file

@deepin-ci-robot
Copy link

Hi @Yurii-huang. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Yurii-huang
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

Yurii-huang
Yurii-huang commented Sep 13, 2024
View reviewed changes
Copy link
Contributor Author

@Yurii-huang Yurii-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepin-mozart

@Yurii-huang
Copy link
Contributor Author

image

image

Kakueeen
Kakueeen reviewed Sep 13, 2024
View reviewed changes
src/plugins/console/consolewidget.cpp Outdated
// U can see schemes path with deepin-os
QString sys_schemes_path = "/usr/share/terminalwidget5/color-schemes";
if (QDir(sys_schemes_path).exists())
addCustomColorSchemeDir(sys_schemes_path);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一块应该放到初始化函数里面，多次调用没有意义

Copy link
Contributor Author

@Yurii-huang Yurii-huang Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait me to change

@Yurii-huang Yurii-huang force-pushed the master branch 2 times, most recently from 767c1cc to a53665f Compare September 13, 2024 09:47
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Yurii-huang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kakueeen Kakueeen Kakueeen left review comments

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yurii-huang @deepin-ci-robot @Kakueeen