-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: new/select/run2 console support #911
Conversation
Yurii-huang
commented
Sep 18, 2024
- add new/select/run2 console service interface
- add logic for console plugin
1.default use system deepin-terminal scheme 2.not found deepin-terminal scheme, use qrc-file scheme file
Hi @Yurii-huang. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. add new/select/run2 console service interface 2. add logic for console plugin
Maybe it's more user-friendly to use service for synchronous calls to functions with return value types, It's up to you to decide whether or not to adopt this suggestion |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepin-mozart, Yurii-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |