Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: new/select/run2 console support #911

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

Yurii-huang
Copy link
Contributor

  1. add new/select/run2 console service interface
  2. add logic for console plugin

Yurii-huang and others added 2 commits September 13, 2024 18:16
1.default use system deepin-terminal scheme
2.not found deepin-terminal scheme, use qrc-file scheme file
@deepin-ci-robot
Copy link

Hi @Yurii-huang. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor Author

@Yurii-huang Yurii-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1. add new/select/run2 console service interface
2. add logic for console plugin
@Yurii-huang
Copy link
Contributor Author

Maybe it's more user-friendly to use service for synchronous calls to functions with return value types,
But for insensitivity to the return value of void, event should be used.

It's up to you to decide whether or not to adopt this suggestion

@deepin-mozart @Kakueeen @LiHua000

@deepin-mozart deepin-mozart merged commit 864849d into linuxdeepin:master Sep 23, 2024
8 of 9 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart, Yurii-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants