Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkcore #65

Merged
merged 1 commit into from
Sep 9, 2024
Merged

sync: from linuxdeepin/dtkcore #65

merged 1 commit into from
Sep 9, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#432

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #66

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#432
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DSysInfo类中新增了UosSmart成员类型,需要确认是否所有相关代码都已更新以支持该类型。
  • CMakeLists.txt文件中删除了对ICU::ucuchardet库的链接,需要确认这是否是有意为之,以及是否会影响其他依赖这些库的代码部分。

是否建议立即修改:

  • 是,需要确保新增的代码部分与现有代码兼容,并且不会引入新的问题。
  • 是,需要验证删除的库ICU::ucuchardet是否在项目中不再被使用,或者是否有替代方案。

@kegechen kegechen merged commit d598e93 into master Sep 9, 2024
11 of 13 checks passed
@kegechen kegechen deleted the sync-pr-432-nosync branch September 9, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants