Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [mount] mount by cifs if cifs supported. #102

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Aug 22, 2024

as title.

Log: as title.

Task: https://pms.uniontech.com/task-view-359651.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • isDaemonMountEnable函数中,对daemonIntroIface.call(kDaemonIntroMethod)的返回值进行了两次包含检查,可能存在重复代码。
  • loginPasswd函数中,对attr.contains(kSchemaDomain)等判断的顺序似乎不必要,因为一旦某个条件不满足,后面的判断就不会执行。
  • loginPasswd函数中的qInfo()调用可能会泄露敏感信息,应该考虑使用日志库来记录信息。
  • isDaemonMountEnable函数中的代码块对于MountControl接口的存在性检查和SupportedFileSystems方法的检查是分开的,这可能不是最高效的设计,可以考虑合并检查以减少不必要的DBus调用。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit 1839ba7 into linuxdeepin:release/eagle Aug 22, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants