Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The mounted Samba network disk prompts that the file has been moved or deleted after the user changes their password #84

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

liyigang1
Copy link
Contributor

Handle EHOSTDOWN errors

Log: The mounted Samba network disk prompts that the file has been moved or deleted after the user changes their password
Bug: https://pms.uniontech.com/bug-view-261605.html

…ved or deleted after the user changes their password

Handle EHOSTDOWN errors

Log: The mounted Samba network disk prompts that the file has been moved or deleted after the user changes their password
Bug: https://pms.uniontech.com/bug-view-261605.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • GetError_En函数中新增的DFM_IO_ERROR_HOST_IS_DOWN错误码没有在DFMIOErrorCode枚举中定义,可能会导致编译错误或未定义行为。
  • dfileinfo.cpp文件中,使用g_error_matches函数检查错误类型和错误信息时,没有考虑可能需要进行类型转换的问题。
  • error.setMessage(gerror->message);这行代码在处理DFM_IO_ERROR_FAILED错误时是多余的,因为gerror->message已经包含了错误信息。
  • 新增的错误处理代码没有考虑到所有可能的错误类型和错误信息,可能需要扩展错误处理逻辑以覆盖所有情况。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, liyigang1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs Johnson-zs merged commit 5b7ab76 into linuxdeepin:release/eagle Jul 11, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants