Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [dfm-mount] can not get part uuid #93

Merged

Conversation

GongHeng2017
Copy link
Contributor

Logic error. the function use error.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-263863.html

Logic error. the function use error.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-263863.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中的函数调用 udisks_partition_dup_name(partition) 可能与 udisks_partition_dup_uuid(partition) 功能重复,需要确认是否有必要保留两个函数调用。
  • 变量 tmpcase Property::kPartitionFlags:case Property::kPartitionUUID: 中被声明但未使用,应该移除未使用的变量以提高代码清晰度。
  • 函数 udisks_partition_dup_type_(partition) 的命名可能存在错误,通常 _ 在 C++ 中用于操作符重载,如果这是一个函数,应该使用其他命名方式。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit 7470fa5 into linuxdeepin:master Jul 30, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants