-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra validations for links, trackers; and news #385
base: master
Are you sure you want to change the base?
Commits on Mar 20, 2024
-
Add extra validations for links, trackers; and news
- bookmarks: unique title, unique URL, force lang definition - news (direct to moderation): force section definition, force lang definition on links, different messages for max length of news title and link title - news (in redaction): force lang definition on links, different messages for max length of news title and link title - trackers: for category definition
Configuration menu - View commit details
-
Copy full SHA for d6ba4d0 - Browse repository at this point
Copy the full SHA d6ba4d0View commit details
Commits on Apr 11, 2024
-
validates lang selection for bookmarks and links
As title and link are both mandatory, we set the lang mandatory too. The "xx" language code is removed from the valid list and blank is refused. The "xx" value was used as default value before we enable "blank" in form. It is not really useful now except for links and bookmarks which are already using this value.
Configuration menu - View commit details
-
Copy full SHA for 84db414 - Browse repository at this point
Copy the full SHA 84db414View commit details -
bookmarks: do not render preview and save button if bookmark is invalid
This way, the errors is easier to see at they appear first on screen.
Configuration menu - View commit details
-
Copy full SHA for ec79de0 - Browse repository at this point
Copy the full SHA ec79de0View commit details -
news: validate association to section and show preview only if valid
This shows a user friendly message instead of an exception if user remove the client side validation of section. The exception were thrown by the preview, so we avoid to show preview and submit button for invalid news.
Configuration menu - View commit details
-
Copy full SHA for 7a706af - Browse repository at this point
Copy the full SHA 7a706afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2552255 - Browse repository at this point
Copy the full SHA 2552255View commit details -
Configuration menu - View commit details
-
Copy full SHA for 676b0ef - Browse repository at this point
Copy the full SHA 676b0efView commit details -
fix typo while copying test from model/link
The bookmark attribute for URL is "link" and not "url".
Configuration menu - View commit details
-
Copy full SHA for e7dffa7 - Browse repository at this point
Copy the full SHA e7dffa7View commit details -
remove unused lang_validation for links
The inclusion validator already does the job correctly.
Configuration menu - View commit details
-
Copy full SHA for 8a91804 - Browse repository at this point
Copy the full SHA 8a91804View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46aeada - Browse repository at this point
Copy the full SHA 46aeadaView commit details