Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README #236

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions README → README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,30 +5,35 @@ cinnamon-desktop contains the libcinnamon-desktop library, the cinnamon-about
program as well as some desktop-wide documents.

The libcinnamon-desktop library provides API shared by several applications
on the desktop, but that cannot live in the platform for various
reasons. There is no API or ABI guarantee, although we are doing our
best to provide stability. Documentation for the API is available with
gtk-doc.
on the desktop, but that cannot live in the platform for various reasons.

There is no API or ABI guarantee, although we are doing our best to provide stability.

Documentation for the API is available with gtk-doc.

Installation
============

1) Run meson with options you like. The following configuration installs
all binaries, libs, and shared files into /usr/local, and enables all
available options:

meson debian/build \
--prefix=/usr/local \
--buildtype=debug \
-D deprecated_warnings=false

```shell
meson debian/build --prefix=/usr/local --buildtype=debug -D deprecation_warnings=false
```

2) Compile and install (sudo is needed for install)

ninja -C debian/build
ninja -C debian/build install

```shell
meson build debian/build
meson compile -C debian/build
meson install -C debian/build
```
Comment on lines -28 to +31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you removed the existing commands and replaced them? The new commands are also duplicative and incorrect. For me, meson build debian/build generates errors but this is also duplicative of the command that works from step 1. This is on systems with meson version 0.61.2. Also, meson compile and meson install both just run the ninja commands from the previous commands that were in the documentation. Same for the uninstall steps that come after this. I don't understand the need to obfuscate those commands.

Apologies if there's any confusion on my part.


3) You can uninstall the installed files with

```shell
meson uninstall debian/build
```

ninja -C debian/build uninstall