Show dual batteries properly in Power Management / Cinnamon Settings #11790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Cinnamon on a ThinkPad T480 with dual batteries. Currently both batteries are shown in the panel applet, but only the internal one is shown in power management:
The reason for that is, as mentioned in #7745, that additional batteries are only shown if they are fully charged or empty. I see no point doing it like that. Adding the other charging states:
Now it's visible, but no percentage and it's impossible to rename it. Also can't see the point for doing it like this. So, after making every battery a "primary battery":
I've also added "PENDING_CHARGE" and "PENDING_DISCHARGE" as separate states, so it's possible to differentiate which battery is in use / being charged. Those will need translations.