make notification states immutable

[hduelme]

Ensuring that notification states are immutable helps prevent any unwanted or accidental modifications.

[rcalixte]

Can you expand on the change here a little bit? What are the differences in the before/after in the user experience? Are there any examples that might be useful?

[hduelme]

Currently anyone using the API (for example spices) could accidental modify the stats, for example MessageTray.Urgency.CRITICAL = 0; could accidental be executed, resulting in a wrong internal state for CRITICAL. This change prevents this. Any changes made to this would be ignored, as cinnamon don't run in strict mode. For the end-user nothing should change at all.

[mtwebster]

Hi, rebased onto current Cinnamon, I get:

Gjs-Message: 09:57:04.741: JS LOG: Enabling WindowAttentionHandler
Gjs-Message: 09:57:08.669: JS LOG: [LookingGlass/error] Urgency is undefined
Gjs-Message: 09:57:08.669: JS LOG: [LookingGlass/trace] 
<----------------
update_list@/usr/share/cinnamon/applets/[email protected]/applet.js:179:1
_notification_added@/usr/share/cinnamon/applets/[email protected]/applet.js:161:14
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
_hideNotificationCompleted@/usr/share/cinnamon/js/ui/messageTray.js:1113:18
_tweenComplete@/usr/share/cinnamon/js/ui/messageTray.js:948:24
_addHandler/params[name]@/usr/share/cinnamon/js/ui/tweener.js:256:24
_callOnFunction@resource:///org/gnome/gjs/modules/script/tweener/tweener.js:190:16
_updateTweenByIndex@resource:///org/gnome/gjs/modules/script/tweener/tweener.js:320:24
_updateTweens@resource:///org/gnome/gjs/modules/script/tweener/tweener.js:333:18
_onEnterFrame@resource:///org/gnome/gjs/modules/script/tweener/tweener.js:348:10
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
_onNewFrame@/usr/share/cinnamon/js/ui/tweener.js:413:14
_init/<@/usr/share/cinnamon/js/ui/tweener.js:389:22
---------------->

[hduelme]

Sorry for my late response. I was able to reproduce the error. The problem occurs because I change var to const. The way the states are accessed requires them to be global scoped. I've reverted them to var to resolve the issue.